12 filters in url param #210
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 14243322 | Triggered | Generic Password | d6f6db3 | app/components/SignIn.js | View secret |
| 14243322 | Triggered | Generic Password | 0562119 | app/components/SignIn.js | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
.vscode/settings.json
Outdated
| @@ -2,8 +2,8 @@ | |||
| "editor.formatOnSave": true, | |||
| "editor.defaultFormatter": "esbenp.prettier-vscode", | |||
| "editor.codeActionsOnSave": { | |||
| "source.fixAll": true, // Auto-fix ESLint issues on save | |||
| "source.fixAll.eslint": true // Specific to ESLint | |||
| "source.fixAll": "explicit", | |||
There was a problem hiding this comment.
make sure not to commit your vscode settings as people will have different configs. the current one auto-formats for prettier/eslint on save so revert this change please
There was a problem hiding this comment.
Yes I had this installed for some other project and accidentally committed this to repo, I'll make sure not to commit that
app/components/FilterList.js
Outdated
| @@ -5,6 +5,7 @@ import styles from '../styles/FilterList.module.css' | |||
| // This file renammes columns to more human-readable names | |||
| import nameMap from '../services/nameMap.js' | |||
|
|
|||
| // need to add functionality such that the | |||
app/components/FilterList.js
Outdated
| if (initialFilters.length > 0) { | ||
| setFilterList(initialFilters) | ||
| } | ||
| }, [setFilterList]) |
There was a problem hiding this comment.
change the dependency list to []. This is more clear and runs on the initial render.
This is also buggy: If I go to http://localhost:3000/matches/Z6F1Amn51528fzmVlHlV?player1ServePlacement=Deuce%3A+Body the filters are not applied. I have to click on the filters tab, then the state is updated.
…e filters. improved render efficiency
|
make sure you run |
|
@Fredenck @krish1925 is this still something we are working on ? |
|
talked to Krish about it, but here's the tldr: yes still being worked on, some more testing needs to be done after the recent changes (deletion of extractSetScores), new Firebase data format, etc |
Solves issue number #12 . Tested on different browsers.