-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sandbox Fatal fixes 01.2024, round 2 #2315
Sandbox Fatal fixes 01.2024, round 2 #2315
Conversation
This reverts commit 328a7df.
The changes of the 2 recent stability PRs appear to improve conversion stability in our sandboxes, bringing roughly 1% improvement to the Fatal severity. Details at: Ready for review. |
@@ -290,7 +290,7 @@ sub DecodeColor { | |||
my $color_re = qr/($color_expr_re)(($func_expr_re)*)/; | |||
|
|||
my $color; | |||
if ($expression =~ /^$color_re$/) { | |||
if ($expression =~ /^$color_re\s*$/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor, but the trailing space wasn't recognized and was creating 50+ needless errors. Example from arXiv:1705.04144:
\documentclass{article}
\usepackage{xcolor}
\begin{document}
\color{rgb, 255:red, 190; green, 190; blue, 190 } Test here.
\end{document}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable; Thanks!
* guard revertScript from inner Tokens * allow deep recursion for computing box sizes in larger tables * allow deep recursion related to digesting parameter reads * fix infinite bibitem loop with OmniBus natbib loading * pgfmath recognizes a single dot as 0 * avoid perl warning for regex on undef * add a couple of latex.ltx internals * guard listings infinite loop * protect IEEEtran.cls.ltxml from renewed definitions of \sc and \it * allow for optional arguments in IEEEtran lists, and rebind the default latex envs * Revert "guard revertScript from inner Tokens" This reverts commit 328a7df. * avoid Fatals in vertical/align checks over document without a root node * allow trailing space in rgb colorspec (see arXiv:1705.04144)
This PR is a (final) follow-up to the just merged #2309 .
I address another handful of Fatal issues, and one minor binding issue:
QUOTED_RE
, but I think there are more general possible pitfalls related tocolnum
not getting incremented and sanity-checked in every possible arm of the loop conditional.\@finalstrut
and\@textsuperscript
were being used, added to LaTeX.pool..
is recognized as zero. So much so that\pgfmathparse{.-.2ex}
is a valid expression.\sc
internally, and a handful of arXiv papers in that class redefined\sc
to be something completely different, wreaking some Fatal havoc. I made two IEEEtran-specific primitives to avoid such clashes.\bibitem
expansion. For some reason not entirely clear to me the\bibitem
DefMacro from natbib didn't stick, and the OmniBus definition expanded into itself in a loop.\lx@nat@bibitem
, and used alet
to bind\bibitem
to it duringnatbib.sty.ltxml
load, which appears to avoid the problem.$text
is always defaulted to an empty string before used in regexes for MathML.pm, which avoids a flurry of pointless perl warnings.Happy to rerun the sandboxes once we merge here, and triple-check we are in good shape for a release tag.