Add VAT clinvar reverse complement #9070
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcovarr
reviewed
Jan 21, 2025
scripts/variantstore/scripts/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
| # Note that inside the clinvar array, are multiple objects that may or may not be the one we are looking for. We check by making sure the ref and alt are the same | ||
| # Note that inside the clinvar array, are multiple objects that may or may not be the one we are looking for. | ||
| # We check by making sure the ref and alt are the same including any reverse complements | ||
| ## TODO add clinvar star rating!!! |
There was a problem hiding this comment.
Are you going to do this work in this ticket or is this another ticket?
Comment on lines
+248
to
+249
| ## TODO add the ("variationId") and the ("reviewStatus")--note that the reviewStatus will need to maintain the ordering of the significance arrays | ||
| ## we need to do this with a tuple so that the reviewStatus lines up with the significance (since significance seems to be an array, while star is a single value) |
There was a problem hiding this comment.
Also wondering if this work is for this ticket / PR or another
There was a problem hiding this comment.
yes another ticket--but I'm in here, it seemed like a waste to not note where it needed to live
scripts/variantstore/scripts/create_vt_bqloadjson_from_annotations.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
successful run here
https://app.terra.bio/#workspaces/gvs-dev/GVS%20Quickstart%20v3%20cremer/job_history/1ea9dccb-da0a-4aea-9f96-701e122ab667