Fix bug that results in an empty Vapor report #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
report_confident_irs_vapor_variants.pyof MakeGqRecalibratorTrainingSetFromPacBio takes in argument--output-detailwhich is intended to output a detailed TSV report of confident variants through VaPoR/IRS analysis. As it currently stands though, no confident VaPoR variants are added to this report. This PR resolves this by ensuring that confident variants are output if a file is passed via--output-detail.Testing
report_confident_irs_vapor_variants.py- note that thevapor_and_irs_detail_reportoutput has no rows in it.report_confident_irs_vapor_variants.py- note that thevapor_and_irs_detail_report_2output has informative data in its rows.