Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lb update to 21 #198

Merged
merged 2 commits into from
Jan 7, 2025
Merged

lb update to 21 #198

merged 2 commits into from
Jan 7, 2025

Conversation

lbergelson
Copy link
Member

  • Updating to java 21
  • update github actions to use java 21

@lbergelson
Copy link
Member Author

@cmnbroad Java 21 is very aggressive with "this-escape" warnings.

@lbergelson lbergelson marked this pull request as ready for review December 18, 2023 21:59
@lbergelson
Copy link
Member Author

We probably don't want to merge this until we have similar branches for the whole pile of repos.

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lbergelson !

Copy link
Collaborator

@cmnbroad cmnbroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new finals could just be replaced with "this-escape" annotations, but otherwise looks good.

* replacing use of deprecated function
* making some methods final and Suppressing some 'this-escape' warnings
* update github actions to use java 21
@lbergelson lbergelson merged commit 1ce1171 into master Jan 7, 2025
3 checks passed
@lbergelson lbergelson deleted the lb_update_to_21 branch January 7, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants