Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit closing if we can't roll the contract. #524

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

brndnmtthws
Copy link
Owner

Follow-up to #523.

@brndnmtthws brndnmtthws merged commit 08ba514 into main Dec 3, 2024
8 checks passed
@brndnmtthws brndnmtthws deleted the maybe-close branch December 3, 2024 16:54
@junyuanz1
Copy link
Collaborator

oh, actually this is better! thanks!

brndnmtthws added a commit that referenced this pull request Dec 3, 2024
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
I completely misunderstood the code in the previous attempt and messed
this up (in #524 and #525).
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
I completely misunderstood the code in the previous attempt and messed
this up (in #524 and #525).
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
I completely misunderstood the code in the previous attempt and messed
this up (in #524 and #525).
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
I completely misunderstood the code in the previous attempt and messed
this up (in #524 and #525).
brndnmtthws added a commit that referenced this pull request Dec 3, 2024
I completely misunderstood the code in the previous attempt and messed
this up (in #524 and #525).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants