Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update curl to version 8.11.1 #185

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jaudiger
Copy link
Contributor

@jaudiger jaudiger commented Jan 20, 2025

Update cURL package to the latest release. I had to add the following flag when building the package: --without-libpsl. Without it, I was getting this error:

ERROR build:bake:bake_inner:run_bake: brioche_core::bake: error=process failed, view full output by runing `brioche jobs logs /home/container/.local/share/brioche/process-temp/01JJ2D87R79C72ZPAXJZD26X5A/events.bin.zst`: process exited with status code exit status: 1
    at file:///workspace/packages/std/core/recipes/process.bri:190:14
    at file:///workspace/packages/curl/project.bri:27:6
    at file:///workspace/packages/curl/project.bri:28:6
    at file:///workspace/packages/std/extra/set_env.bri:50:25
    at file:///workspace/packages/curl/project.bri:30:14
    at file:///workspace/packages/std/extra/set_env.bri:61:23 scope=Project { project_hash: ProjectHash(Hash("0ab973073f06009c8336f33a01dfee09b2021b416c178e73055bb7a75ed4b825")), export: "default" } recipe_hash=07af32e16bba5c8df9528be6661ed1f7f9302f8b99c74546b814bbc2ebd9a4ca recipe_kind=Insert recipe_hash=07af32e16bba5c8df9528be6661ed1f7f9302f8b99c74546b814bbc2ebd9a4ca recipe_kind=Insert
13866  │ checking for AWS-LC... no
       │ checking for LibreSSL... no
       │ checking for OpenSSL >= v3... yes
       │ checking for SSL_set_quic_use_legacy_codepoint... no
       │ configure: OpenSSL version does not speak QUIC API
       │ checking for SRP support in OpenSSL... yes
       │ checking for QUIC support and OpenSSL >= 3.3... yes
       │ configure: built with one SSL backend
       │ checking default CA cert bundle/path... configure: want no ca no
       │ no
       │ checking whether to use built-in CA store of SSL library... yes
       │ checking CA cert bundle path to embed in the curl tool... no
       │ checking for pkg-config... (cached) /home/brioche-runner-346af3b030acc435cf524e5bdc732dc9cc7c7f80221366eb159c320d779a0b81/.local/share/brioche/locals/e1ed32b0f032eb21008a38d286836b9b8
       │ 41956370cebbbd006b5c1eb3c952710/bin/pkg-config
       │ checking for libpsl options with pkg-config... no
       │ checking for psl_builtin in -lpsl... no
       │ configure: error: libpsl libs and/or directories were not found where specified!

After having looked at nixpkgs and homebrew, both do not build by default with the library PSL. For example, from homebrew:

https://github.com/Homebrew/homebrew-core/blob/00aef4629a67551b17040cc8f9a85610a26c26e7/Formula/c/curl.rb:
image

Signed-off-by: Jérémy Audiger <[email protected]>
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Wonder if we should revisit to add support for libpsl as a followup? The Curl docs (https://everything.curl.dev/build/deps.html#libpsl) say its used for handling cookies properly, not something that I imagine most users would hit but maybe nice to support

@kylewlacy kylewlacy merged commit 47da40a into brioche-dev:main Jan 20, 2025
3 checks passed
@jaudiger jaudiger deleted the update-curl-package branch January 21, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants