Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(asciinema): update source retrieval method to use tar.gz archive #171

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

jaudiger
Copy link
Contributor

But maybe there was a reason to not having used the method Brioche.download.

@jaudiger jaudiger requested a review from kylewlacy January 19, 2025 13:14
Copy link
Member

@kylewlacy kylewlacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a while, I ended up defaulting to using git directly over GitHub's source tarballs, but I definitely wasn't consistent with it so I think it makes sense to stick to using Brioche.download as the default since that matches what the majority of packages are doing

It might be worth revisiting what the default should be. My fear is that we could hit breakages one day because GitHub doesn't guarantee that their source tarballs are always byte-for-byte identical, whereas git hashes should have stronger guarantees. But for now, I think it's the right call to stick with the default and split that out as a separate issue to consider

@kylewlacy
Copy link
Member

As a follow up, I opened a Discussion around using Brioche.download() vs. Brioche.gitRef() for downloading sources for GitHub releases here: #176

@kylewlacy kylewlacy merged commit a85be88 into brioche-dev:main Jan 20, 2025
3 checks passed
@jaudiger jaudiger deleted the update-asciinema branch January 20, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants