Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSA: save two copies during private key operations. #2310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

briansmith
Copy link
Owner

Instead of converting the base from base/R to baseR in place and then copying it into the storage, just write baseR directly into the storage.

@briansmith briansmith self-assigned this Jan 31, 2025
@briansmith briansmith changed the title RSA: save two copies during private key operations on x86-64. RSA: save two copies during private key operations. Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 94.93671% with 4 lines in your changes missing coverage. Please review.

Project coverage is 96.70%. Comparing base (c28bdc5) to head (98235a1).

Files with missing lines Patch % Lines
src/arithmetic/bigint.rs 94.80% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2310      +/-   ##
==========================================
- Coverage   96.71%   96.70%   -0.02%     
==========================================
  Files         176      176              
  Lines       21123    21176      +53     
  Branches      492      493       +1     
==========================================
+ Hits        20430    20478      +48     
- Misses        590      593       +3     
- Partials      103      105       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Instead of converting the base from base/R to base*R in place and then
copying it into the storage, just write base*R directly into the
storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant