arithmetic: Pass inputs to limbs_mul_mont as slices.
#2247
Merged
+71
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Be more consistent with the non-squaring Montgomery multiplication functions.
Remove some gratuitous unsafety. In theory there are many patterns of aliasing the arguments when calling `bn_mul_mont`, but in practice we only have three: 1. r *= a (mod n) 2. r = a * b (mod n) 3. r = r * r (mod n) Rename `mul_mont` to `limbs_mul_mont` and have it handle both #1 & #2. Refactor it so that its arguments are slices. Remove the `limbs_mont_mul` and `limbs_mont_product` wrappers around `limbs_mul_mont` in favor of exposing `limbs_mul_mont` directly. Change `limbs_square_mont` to call `bn_mul_mont` directly. Although we could have `mul_mont` handle this by making the new `InOut` type more complicated, but we'd just end up undoing this when `bn_mul_mont` is split into separate squaring and non-squaring functions later.
briansmith
force-pushed
the
b/bn-mul-mont-split-square
branch
from
8a7e660 to
8f4d5f0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2247 +/- ##
==========================================
- Coverage 96.89% 96.88% -0.01%
==========================================
Files 167 167
Lines 20687 20661 -26
Branches 475 475
==========================================
- Hits 20044 20018 -26
Misses 546 546
Partials 97 97 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for details.