chacha20_poly1305_openssh: Rename confusing variable (NFC). #2231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`open_in_place` takes ciphertext in and outputs plaintext, and it already has a local variable with a name to that effect. It is very confusing to then have a variable named `plaintext_in_ciphertext_out` in this function. Probably it was copy-pasta from `seal_in_place`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2231 +/- ##
==========================================
- Coverage 97.00% 97.00% -0.01%
==========================================
Files 165 165
Lines 20511 20509 -2
Branches 464 464
==========================================
- Hits 19897 19895 -2
Misses 505 505
Partials 109 109 ☔ View full report in Codecov by Sentry. |
briansmith
deleted the
b/chacha20_poly1305_openssh-rename-confusing-variable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open_in_placetakes ciphertext in and outputs plaintext, and it already has a local variable with a name to that effect. It is very confusing to then have a variable namedplaintext_in_ciphertext_outin this function. Probably it was copy-pasta fromseal_in_place.