Skip to content

Commit

Permalink
Modified setup.py's EXTRA_OBJECTS setting to use an empty set ([] vs '')
Browse files Browse the repository at this point in the history
when the variable isn't found in the check.  The empty value is
problematic for distutils, but NCAR's compiler wrappers eliminate the
empty space, whereas directly calling the compilers does not - this
leads to build problems on other systems.  (Usually hidden because it's
installed via Conda in most cases.)

I'm very bad at python, so my terminology above is likely incorrect, but
I'm quite sure the diagnosis is right.  :-)
  • Loading branch information
briandobbins committed Mar 2, 2021
1 parent 2b772b6 commit 1dd5fc0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,7 @@ def set_curl_libs():
try:
EXTRA_OBJECTS = [os.environ["EXTRA_OBJECTS"]]
except:
EXTRA_OBJECTS = ''
EXTRA_OBJECTS = []

#
# Done with environment variables.
Expand Down

0 comments on commit 1dd5fc0

Please sign in to comment.