Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.2 - Fix size parameter in tests #9

Merged
merged 3 commits into from
Sep 5, 2024
Merged

0.2.2 - Fix size parameter in tests #9

merged 3 commits into from
Sep 5, 2024

Conversation

brendancsmith
Copy link
Owner

@brendancsmith brendancsmith commented Sep 5, 2024

Fixes size parameter (from limit) and adds vscode launch.json

Summary by Sourcery

Fix the parameter name from 'limit' to 'size' in test cases to align with the expected API usage and add a VSCode launch.json file for improved development experience.

Bug Fixes:

  • Correct the parameter name from 'limit' to 'size' in test cases to ensure proper functionality.

Enhancements:

  • Add a VSCode launch.json configuration file to facilitate debugging.

Copy link

trunk-io bot commented Sep 5, 2024

😎 Merged manually by Brendan Smith (@brendancsmith) - details.

Copy link

sourcery-ai bot commented Sep 5, 2024

Reviewer's Guide by Sourcery

This pull request fixes the size parameter in the enhance and search client tests, replacing 'limit' with 'size'. It also adds a VSCode launch.json file, although this change is not visible in the provided diff.

File-Level Changes

Change Details Files
Replace 'limit' parameter with 'size' in test query parameters
  • Update test_mocked_enhance to use 'size' instead of 'limit'
  • Update test_mocked_create_bulkjob to use 'size' instead of 'limit'
  • Update test_mocked_search to use 'size' instead of 'limit'
tests/unit/clients/test_enhance_client.py
tests/unit/clients/test_search_client.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brendancsmith - I've reviewed your changes - here's some feedback:

Overall Comments:

  • The changes look good, but consider doing a broader search in the codebase for any remaining instances of the 'limit' parameter to ensure complete consistency with the new 'size' parameter.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@brendancsmith brendancsmith changed the title 0.2.2 - Fix size parameter 0.2.2 - Fix size parameter in tests Sep 5, 2024
@brendancsmith brendancsmith merged commit b8a1356 into main Sep 5, 2024
4 checks passed
@brendancsmith brendancsmith deleted the dev branch September 5, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant