-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications #76
Notifications #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JssDWt I think this is great! I dropped some comments to discuss.
aba6f14
to
ddd0f24
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's probably better to resume the htlc and let the lightning implementation decide that the next peer is unknown rather than explicitly returning UNKNOWN_NEXT_PEER in lspd.
More efficient peer online and scid lookups are out of scope for this PR and is tracked by this issue: #77 |
Merged into this PR more efficient lookups of peer id based on scid and more efficient waiting for the peer to come online (that was blocking this PR to be merged) #78 |
Closing this in favor of #88 |
Add notifications when the peer is offline.
This is a very basic implementation of #63. It does not include the following features yet:
Note that the time period for holding the htlc might get tricky when you get close to the cltv delta. So the holding period should generally be short.