Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewards 3.0] Clear unsupported Rewards notifications on page load #27331

Merged
merged 1 commit into from
Jan 24, 2025

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jan 23, 2025

Resolves brave/brave-browser#43450

Instead of filtering notification on the browser side, all notifications are sent to the front-end; the front-end will decide to either display the notification or delete it.

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@zenparsing zenparsing merged commit 9147a5e into master Jan 24, 2025
19 checks passed
@zenparsing zenparsing deleted the ksmith-rewards-3-badge-count branch January 24, 2025 02:06
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AC completed notification badge shown on 1.75.x if notification is not dismissed on 1.74.x
2 participants