Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert brave_component_updater to component target type. #27304

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

goodov
Copy link
Member

@goodov goodov commented Jan 22, 2025

Fix singleton sharing across component/non-component targets.

Resolves brave/brave-browser#43412

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov force-pushed the brave_component_updater_as_component branch from 597010c to 8264f51 Compare January 22, 2025 09:20
@goodov goodov changed the title Convert brave_component_updater to compnent target type. Convert brave_component_updater to component target type. Jan 22, 2025
@goodov goodov marked this pull request as ready for review January 22, 2025 10:34
@goodov goodov requested review from a team, bridiver and antonok-edm as code owners January 22, 2025 10:34
Copy link
Collaborator

@kylehickinson kylehickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ios++

@goodov goodov merged commit 13d806a into master Jan 23, 2025
20 checks passed
@goodov goodov deleted the brave_component_updater_as_component branch January 23, 2025 09:57
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 23, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BraveOnDemandUpdater in component build can CHECK
4 participants