Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webcompat reporter] BlockScripts & CookiePolicy should contain current URL related values #27281

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Jan 20, 2025

Resolves brave/brave-browser#43394

Changed the way how we fill the next webcompat report parameters:

  • BlockScripts
  • CookiePolicy

It should use values we set on the shields panel for specific URL

Platform Screenshot
Desktop image
Android image
iOS image

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@vadimstruts vadimstruts marked this pull request as ready for review January 20, 2025 20:22
@vadimstruts vadimstruts requested a review from a team as a code owner January 20, 2025 20:22
Copy link
Collaborator

@StephenHeaps StephenHeaps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS++

Signed-off-by: Vadym Struts <[email protected]>
Copy link
Contributor

The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "policy" and so security team members have been added as reviewers to take a look.

No need to request a full security review at this stage, the security team will take a look shortly and either clear the label or request more information/changes.

Notifications have already been sent, but if this is blocking your merge feel free to reach out directly to the security team on Slack so that we can expedite this check.

@vadimstruts vadimstruts merged commit 79ed497 into master Jan 20, 2025
18 checks passed
@vadimstruts vadimstruts deleted the webcompat_block_script_flag_for_webpage branch January 20, 2025 22:44
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 20, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Webcompat reporter] BlockScripts & CookiePolicy should contain current URL related values
5 participants