Fix UNSAFE_TODO for wallet

[supermassive]

Resolves brave/brave-browser#42595

Fixes of UNSAFE_TODO for wallet + touched some other components.

Submitter Checklist:

• I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally:
  • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
  • npm run presubmit wiki, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

[github-actions]

[puLL-Merge] - brave/brave-core@27247

Description

This PR makes several changes to the Brave browser codebase, primarily focusing on updating function signatures and improving code style. The changes aim to modernize the codebase, improve readability, and potentially enhance performance.

Changes

Changes

1. browser/ui/webui/brave_webui_source.cc:

   • Updated CreateWebUIDataSource and CreateAndAddWebUIDataSource function signatures to use base::span instead of separate pointer and size parameters.
   • Removed resource_map_size parameter from function calls.

2. browser/ui/webui/*.cc files:

   • Updated function calls to CreateAndAddWebUIDataSource to remove the *GeneratedSize parameter.

3. components/brave_wallet/browser/eth_gas_utils.cc:

   • Improved code style and readability in GetSuggested1559Fees function.
   • Replaced C-style arrays with std::array.

4. components/brave_wallet/browser/ethereum_keyring_unittest.cc:

   • Replaced C-style array with std::to_array.
   • Improved code style and readability.

5. ios/browser/ui/webui/brave_webui_source.h and .mm:

   • Updated function signatures to use base::span.
   • Removed resource_map_size parameter.

6. Various files:

   • Added braces to single-line if statements for consistency and to prevent potential bugs.

sequenceDiagram
    participant Developer
    participant CodeBase
    participant BuildSystem
    Developer->>CodeBase: Update function signatures
    CodeBase->>BuildSystem: Propagate changes
    BuildSystem->>Developer: Compile and verify changes
    Developer->>CodeBase: Improve code style
    CodeBase->>BuildSystem: Rebuild with style improvements
    BuildSystem->>Developer: Confirm successful build

Loading

Possible Issues

No major non-security issues are apparent in this change.

Security Hotspots

There are no significant security hotspots in this change. The modifications are primarily focused on code style and modernization, which generally do not introduce new security risks.

This sequence diagram illustrates the process of updating function signatures and improving code style in the Brave browser codebase. The developer makes changes to the codebase, which are then propagated through the build system. The build system compiles and verifies the changes, providing feedback to the developer. This process is repeated for code style improvements.

[zenparsing]

Rewards 👍

[brave-builds]

Released in v1.76.20