Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed split view menu bubble is not hidden after command runs #27225

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 14, 2025

fix brave/brave-browser#43253

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong self-assigned this Jan 14, 2025
@simonhong simonhong marked this pull request as ready for review January 14, 2025 11:41
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

browser/ui/views/split_view/split_view_menu_bubble.cc Outdated Show resolved Hide resolved
@simonhong simonhong enabled auto-merge January 15, 2025 00:51
@simonhong simonhong merged commit c0022fb into master Jan 15, 2025
18 checks passed
@simonhong simonhong deleted the fix_split_view_menu_bubble_visibility branch January 15, 2025 01:58
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 15, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split tabs menu is not dismissed even after moving tabs out of split view
3 participants