Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use system context menu in vertical tab on Windows #27173

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jan 9, 2025

fix brave/brave-browser#43197

It should use same context menu with horizontal tab's one in title bar area.
In addition to the result of frame()->GetSystemMenuModel(),
windows includes addiitonal entries. So, the result frame()->GetSystemMenuModel() added
separator at last for it.

Screenshot 2025-01-09 173241
Screenshot 2025-01-09 173251

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue.

fix brave/brave-browser#43197

It should use same context menu with horizontal tab's one in title bar
area.
@simonhong simonhong self-assigned this Jan 9, 2025
@simonhong simonhong marked this pull request as ready for review January 9, 2025 08:34
@simonhong simonhong merged commit 509b6d9 into master Jan 9, 2025
19 checks passed
@simonhong simonhong deleted the context_menu_on_vertical_tab branch January 9, 2025 23:51
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 9, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty entry in the context menu of vertical tab
3 participants