Adds screenshot options to context menu and commands #27083

jonathansampson · 2024-12-21T12:55:50Z

Resolves brave/brave-browser#25816
Security/Privacy Review: https://github.com/brave/reviews/issues/1831

screenshot-context-menu.mp4

Submitter Checklist:

I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on
All relevant documentation has been updated, for instance:

Test Plan:

Right-click on a page
Click Screenshot Tools from the context menu
Select an option (i.e., Selection, Viewport, Full page) from the submenu

Once a screenshot has been taken, you should see a UI element (with a preview of your screenshot) informing you that the screenshot has been copied to your device's clipboard.

jonathansampson · 2025-01-02T15:03:09Z

I've refactored this into a TabHelper pattern, with deferred attachment (until user requests a screenshot). Commits landing here in a bit.

bridiver · 2025-01-02T18:39:33Z

I've refactored this into a TabHelper pattern, with deferred attachment (until user requests a screenshot). Commits landing here in a bit.

Make sure you follow the latest updates using TabInterface and not WebContentsUserData

jonathansampson · 2025-01-02T18:40:42Z

I've refactored this into a TabHelper pattern, with deferred attachment (until user requests a screenshot). Commits landing here in a bit.

Make sure you follow the latest updates using TabInterface and not WebContentsUserData

Looking into that now. Thanks!

app/brave_generated_resources.grd

browser/brave_screenshots/screenshots_tab_feature.h

browser/brave_screenshots/screenshots_utils.cc

chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc

fallaciousreasoning

lgtm % nits

If there is nothing selected, we shouldn't attempt to construct an autocomplete match, run the autocomplete classifier, etc. Furthermore, this enables us to simplify tests involving the context menu due to reduced setup.

After rebasing, there is now a failure in this PR unrelated to the contents or changes introduced by the PR itself. A fresh build from scratch will resolve this, but a component build will proceed if any change is made to the policy template file. As such, a typo has been found and fixed so as to 1) Improve the comments, and importantly 2) Fix the build 😀 See https://bravesoftware.slack.com/archives/C7VLGSR55/p1736928018175489?thread_ts=1736911378.517619&cid=C7VLGSR55 for more info.

Removes unused parameters and prefers simpler constructor pattern

github-actions · 2025-01-22T20:21:37Z

[puLL-Merge] - brave/brave-core@27083

Description

This PR introduces screenshot functionality to the Brave browser, allowing users to capture full-page screenshots, viewport screenshots, and selected regions. The implementation includes context menu integration and clipboard support.

Changes

Changes

Command IDs and Strings (app/)

Added new command IDs for screenshot tools
Added localized strings for screenshot menu items

Screenshots Feature Implementation (browser/brave_screenshots/)

Implemented three screenshot strategies:
- FullPageStrategy: Captures entire webpage
- ViewportStrategy: Captures visible portion
- SelectionStrategy: Captures user-selected region
Added feature flag control (kBraveScreenshots)
Implemented clipboard integration for captured screenshots

UI Integration

Added screenshot options to context menu
Added command handling in BraveBrowserCommandController
Integrated with browser commands system

Build System

Added new GN build files for screenshots feature
Added conditional compilation based on platform

sequenceDiagram
    participant User
    participant ContextMenu
    participant BraveScreenshotsTabFeature
    participant ScreenshotStrategy
    participant Clipboard

    User->>ContextMenu: Right-click
    ContextMenu->>ContextMenu: MaybeBuildBraveScreenshotsMenu()
    User->>ContextMenu: Select Screenshot Option
    ContextMenu->>BraveScreenshotsTabFeature: StartScreenshot()
    BraveScreenshotsTabFeature->>ScreenshotStrategy: CreateStrategy()
    ScreenshotStrategy->>ScreenshotStrategy: Capture()
    ScreenshotStrategy-->>BraveScreenshotsTabFeature: OnCaptureComplete()
    BraveScreenshotsTabFeature->>Clipboard: CopyImageToClipboard()
    BraveScreenshotsTabFeature->>User: DisplayScreenshotBubble()

Possible Issues

Large screenshots may be clipped due to GPU texture size limits (16384x16384)
Screenshot notification for clipped images is not yet implemented (marked as NOTIMPLEMENTED)

Security Hotspots

DevTools Protocol usage in FullPageStrategy could potentially expose sensitive information if not properly sanitized
Clipboard operations need proper validation to prevent memory/resource exhaustion

browser/brave_screenshots/screenshots_tab_feature.cc

bridiver · 2025-01-22T20:33:00Z

browser/ui/BUILD.gn

@@ -103,6 +104,18 @@ source_set("ui") {
    "webui/skus_internals_ui.h",
  ]

+  if (enable_brave_screenshots) {
+    sources += [


this should have it's on BUILD.gn and these sources definitely do not belong in browser/ui/BUILD.gn because they aren't even in browser/ui

not sure yet if they should be in browser/ui instead, but either way there should be a BUILD.gn for the directory

also these sources exist in multiple places so something is definitely weird here if you're not getting any errors

oh, there are no errors because they are .h files, but you should not be adding files like this

jonathansampson added enhancement CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Dec 21, 2024

jonathansampson self-assigned this Dec 21, 2024

github-actions bot added the CI/run-upstream-tests Run upstream unit and browser tests on Linux and Windows (otherwise only on Linux) label Dec 21, 2024

jonathansampson marked this pull request as ready for review December 23, 2024 04:48

jonathansampson requested review from a team and bridiver as code owners December 23, 2024 04:48

jonathansampson marked this pull request as draft December 26, 2024 22:48

jonathansampson force-pushed the sampson-brave-screenshots branch 2 times, most recently from 0e69a8a to 4b7451d Compare December 28, 2024 23:18

jonathansampson marked this pull request as ready for review December 29, 2024 02:58

jonathansampson requested review from fallaciousreasoning and cdesouza-chromium December 29, 2024 02:58

jonathansampson marked this pull request as draft January 2, 2025 21:17

jonathansampson force-pushed the sampson-brave-screenshots branch 2 times, most recently from 22868e1 to fdd6104 Compare January 4, 2025 17:34

github-actions bot added the CI/run-network-audit Run network-audit label Jan 4, 2025

fallaciousreasoning reviewed Jan 5, 2025

View reviewed changes

app/brave_generated_resources.grd Outdated Show resolved Hide resolved

fallaciousreasoning reviewed Jan 5, 2025

View reviewed changes

browser/brave_screenshots/screenshots_tab_feature.h Outdated Show resolved Hide resolved

fallaciousreasoning reviewed Jan 5, 2025

View reviewed changes

browser/brave_screenshots/screenshots_utils.cc Outdated Show resolved Hide resolved

fallaciousreasoning reviewed Jan 5, 2025

View reviewed changes

chromium_src/chrome/browser/renderer_context_menu/render_view_context_menu.cc Outdated Show resolved Hide resolved

fallaciousreasoning approved these changes Jan 5, 2025

View reviewed changes

jonathansampson marked this pull request as ready for review January 7, 2025 14:04

jonathansampson added 24 commits January 22, 2025 13:43

moves screenshot strings to own file

087983a

Don't show the submenu within devtools

7d62a4a

refactors devtools code into distinct helper

e0b19f4

pesubmit fixes

c62a514

avoid forward declarations per style guide

e5cf97c

Skip autocomplete classifier on empty selection

6a799aa

If there is nothing selected, we shouldn't attempt to construct an autocomplete match, run the autocomplete classifier, etc. Furthermore, this enables us to simplify tests involving the context menu due to reduced setup.

adds context-menu related unittests for screenshots

39e05b5

cleanup and simplify unit tests

99521cc

dependency cleanup

025eccb

moves to strategy-based screenshotting

476f49b

Simplifies clip-indicating member

bfd9bb2

Update screenshots_tab_feature.cc

debb5b7

adds some comments around screenshot limitations

6947a0e

minor note changes

cd3fe53

removes unused includes

360dc12

clean up build.gn deps

af98f54

uses explicit/intentional targets

8e5bed9

uses debug logs

5ccd6b4

addressing minor feedback items

8d43dbe

adds GitHub Issue reference

10153c9

removes unused include

ed6df8d

removes explicit targets

16b8367

clean up tests

1862009

Removes unused parameters and prefers simpler constructor pattern

jonathansampson force-pushed the sampson-brave-screenshots branch from 4bf06f9 to 1862009 Compare January 22, 2025 20:20

bridiver reviewed Jan 22, 2025

View reviewed changes

browser/brave_screenshots/screenshots_tab_feature.cc Outdated Show resolved Hide resolved

bridiver reviewed Jan 22, 2025

View reviewed changes

jonathansampson added 2 commits January 22, 2025 14:42

filenames and classnames should match

773a835

presubmit fixes

6a44374

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds screenshot options to context menu and commands #27083

Adds screenshot options to context menu and commands #27083

jonathansampson commented Dec 21, 2024 •

edited

Loading

jonathansampson commented Jan 2, 2025

bridiver commented Jan 2, 2025

jonathansampson commented Jan 2, 2025

fallaciousreasoning left a comment

github-actions bot commented Jan 22, 2025

Changes

bridiver Jan 22, 2025

bridiver Jan 22, 2025

bridiver Jan 22, 2025

bridiver Jan 22, 2025

Adds screenshot options to context menu and commands #27083

Are you sure you want to change the base?

Adds screenshot options to context menu and commands #27083

Conversation

jonathansampson commented Dec 21, 2024 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

jonathansampson commented Jan 2, 2025

bridiver commented Jan 2, 2025

jonathansampson commented Jan 2, 2025

fallaciousreasoning left a comment

Choose a reason for hiding this comment

github-actions bot commented Jan 22, 2025

Description

Changes

Possible Issues

Security Hotspots

bridiver Jan 22, 2025

Choose a reason for hiding this comment

bridiver Jan 22, 2025

Choose a reason for hiding this comment

bridiver Jan 22, 2025

Choose a reason for hiding this comment

bridiver Jan 22, 2025

Choose a reason for hiding this comment

jonathansampson commented Dec 21, 2024 •

edited

Loading