Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rewards throttle if rewards is enabled #26901

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Dec 6, 2024

Resolves brave/brave-browser#39437

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@deeppandya deeppandya added this to the 1.75.x - Nightly milestone Dec 6, 2024
@deeppandya deeppandya requested review from bridiver and a team December 6, 2024 11:40
@deeppandya deeppandya self-assigned this Dec 6, 2024
@deeppandya deeppandya marked this pull request as draft December 6, 2024 20:35
@deeppandya deeppandya force-pushed the add_rewards_throttle_if_enabled branch from b2ed749 to 469a8fa Compare December 9, 2024 09:06
@deeppandya deeppandya marked this pull request as ready for review December 9, 2024 09:07
@deeppandya deeppandya marked this pull request as draft December 9, 2024 09:10
@deeppandya deeppandya force-pushed the add_rewards_throttle_if_enabled branch from 469a8fa to c2fde0e Compare December 9, 2024 09:35
@deeppandya deeppandya marked this pull request as ready for review December 9, 2024 18:17
@deeppandya deeppandya merged commit 11dce3c into master Jan 23, 2025
18 checks passed
@deeppandya deeppandya deleted the add_rewards_throttle_if_enabled branch January 23, 2025 20:20
@brave-builds
Copy link
Collaborator

Released in v1.76.36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rewards throttle only if rewards is enabled
3 participants