Skip to content

Commit

Permalink
Review fix
Browse files Browse the repository at this point in the history
  • Loading branch information
cypt4 committed Jan 22, 2025
1 parent 5293a34 commit 632e42b
Showing 1 changed file with 10 additions and 15 deletions.
25 changes: 10 additions & 15 deletions components/brave_wallet/browser/zcash/zcash_wallet_service.cc
Original file line number Diff line number Diff line change
Expand Up @@ -660,16 +660,14 @@ void ZCashWalletService::CreateTransparentToOrchardTransaction(

void ZCashWalletService::CreateTransactionTaskDone(
ZCashCreateTransparentToOrchardTransactionTask* task) {
bool removed = create_shield_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; });
DCHECK(removed);
CHECK(create_shield_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; }));
}

void ZCashWalletService::CreateTransactionTaskDone(
ZCashCreateOrchardToOrchardTransactionTask* task) {
bool removed = create_shielded_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; });
DCHECK(removed);
CHECK(create_shielded_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; }));
}

void ZCashWalletService::CreateShieldAllTransactionTaskDone(
Expand Down Expand Up @@ -863,22 +861,19 @@ void ZCashWalletService::OnTransactionResolvedForStatus(

void ZCashWalletService::CompleteTransactionTaskDone(
ZCashCompleteTransactionTask* task) {
bool removed = complete_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; });
DCHECK(removed);
CHECK(complete_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; }));
}

void ZCashWalletService::CreateTransactionTaskDone(
ZCashCreateTransparentTransactionTask* task) {
bool removed = create_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; });
DCHECK(removed);
CHECK(create_transaction_tasks_.remove_if(
[task](auto& item) { return item.get() == task; }));
}

void ZCashWalletService::ResolveBalanceTaskDone(ZCashResolveBalanceTask* task) {
bool removed = resolve_balance_tasks_.remove_if(
[task](auto& item) { return item.get() == task; });
DCHECK(removed);
CHECK(resolve_balance_tasks_.remove_if(
[task](auto& item) { return item.get() == task; }));
}

ZCashRpc& ZCashWalletService::zcash_rpc() {
Expand Down

0 comments on commit 632e42b

Please sign in to comment.