Skip to content

Commit

Permalink
Disable SaveImageMultipleTimes browser test on x64 (uplift to 1.74.x) (
Browse files Browse the repository at this point in the history
…#27153)

Uplift of #27103 (squashed) to beta
  • Loading branch information
brave-builds authored Jan 8, 2025
1 parent b8c4625 commit 4a72dda
Showing 1 changed file with 10 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "base/threading/thread_restrictions.h"
#include "brave/browser/ntp_background/constants.h"
#include "brave/components/constants/brave_paths.h"
#include "build/build_config.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/test/base/in_process_browser_test.h"
Expand Down Expand Up @@ -111,8 +112,16 @@ IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
EXPECT_TRUE(base::PathExists(test_file()));
}

// On Mac x64 CI node we presume this test crashes the whole suite.
// https://github.com/brave/brave-browser/issues/38988
#if BUILDFLAG(IS_MAC) && defined(ARCH_CPU_ARM_FAMILY)
#define MAYBE_SaveImageMultipleTimes SaveImageMultipleTimes
#else
#define MAYBE_SaveImageMultipleTimes DISABLED_SaveImageMultipleTimes
#endif

IN_PROC_BROWSER_TEST_F(CustomBackgroundFileManagerBrowserTest,
SaveImageMultipleTimes) {
MAYBE_SaveImageMultipleTimes) {
for (int i = 0; i < 3; i++) {
base::RunLoop run_loop;
base::FilePath expected_path =
Expand Down

0 comments on commit 4a72dda

Please sign in to comment.