Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused OtherProjectiveType from benchmark macros #79

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jul 24, 2024

This argument was never used; instead the macros just use the base curve Config from the first argument. This led to unused type declaration warnings when the macro was expanded.

This argument was never used; instead the macros just use the
base curve `Config` from the first argument. This led to
unused type declaration warnings.
@rillian rillian requested review from claucece and ankeleralph July 24, 2024 17:26
@rillian rillian self-assigned this Jul 24, 2024
@rillian rillian mentioned this pull request Jul 24, 2024
Copy link
Collaborator

@ankeleralph ankeleralph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me :)

@rillian rillian merged commit 24d7ae9 into main Jul 29, 2024
3 of 4 checks passed
@rillian rillian deleted the OtherProjectiveType branch July 29, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants