Pass more arguments by reference #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was unused, and unncessary since the member variable is public and can be accessed directly.
Avoid cloning these objects when the callee only needs temporary access to the data.
Avoid cloning these objects when the callee only needs temporary access to the data.
Take a few values by reference to avoid having to `clone()` them at call sites, and simplify generator construction so it's more clear how many copies are needed.
Make similar changes to the previous commit.
Remove further clone calls as an optimization.
Optimize and clean up argument passing to reduce the number of clone calls.
Update function signatures to not require a clone of the `KeyPair` struct when they only need temporary read access to the values. Looks cleaner and should be more efficient.
Further clean up to remove clone method calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General code clean up: change some functions to take arguments by reference instead of value so the call site doesn't have to call
cloneas much. Less cluttered source and avoids making unnecessary copies.Much more to do in the direction, but this is a first pass.