Replace explicit loop counters #76
Conversation
Clippy doesn't like index variables and issues a warning here, recommending an equally-cumbersome functional equivalent. Instead, combine the sequences mnd ap them to the evaluated values directly. This may also optimize better than manual indexing because it's easier for the compiler to eliminate initialization and bounds checks.
Addresses a clippy lint.
Address these clippy lints by annotating the functions as expected. Clippy is correct this is unfriendly API design, but for lower-level cryptography it's better to match the mathematical notation of the literature.
Use the `exp_iter` util instead of a manual accumulator for the sequence of exponents of y in the r1cs prover. Addresses a `clippy::needless_range_loop` lint, and should optimize better. Fixup iterator patch
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -682,6 +683,9 @@ impl<'g, G: AffineRepr, T: BorrowMut<Transcript>> Prover<'g, G, T> { | |||
| .chain(s_L2.iter()) | |||
| .zip(s_R1.iter().chain(s_R2.iter())); | |||
| for (i, (sl, sr)) in sLsR.enumerate() { | |||
| // y^i -> y^(i+1) | |||
| let exp_y = exp_y_iter.next() | |||
| .expect("exponentional iterator shouldn't terminate"); | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
There was a problem hiding this comment.
The current FrExp impl is non-terminating, so the guard here is only to catch incompatible code changes. I think that's better as a panic than a error result, but don't feel strongly about it.
|
yes!! |
| @@ -682,6 +683,9 @@ impl<'g, G: AffineRepr, T: BorrowMut<Transcript>> Prover<'g, G, T> { | |||
| .chain(s_L2.iter()) | |||
| .zip(s_R1.iter().chain(s_R2.iter())); | |||
| for (i, (sl, sr)) in sLsR.enumerate() { | |||
| // y^i -> y^(i+1) | |||
| let exp_y = exp_y_iter.next() | |||
| .expect("exponentional iterator shouldn't terminate"); | |||
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
| } | ||
| r_vec.resize_with(padded_n, || { | ||
| let exp_y = exp_y_iter.next() | ||
| .expect("exponentional iterator shouldn't terminate"); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
| // y^i -> y^(i+1) | ||
| let exp_y = exp_y_iter | ||
| .next() | ||
| .expect("exponentional iterator shouldn't terminate"); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
| r_vec.resize_with(padded_n, || { | ||
| let exp_y = exp_y_iter | ||
| .next() | ||
| .expect("exponentional iterator shouldn't terminate"); |
There was a problem hiding this comment.
reported by reviewdog 🐶
[semgrep] expect or unwrap called in function returning a Result
Source: https://semgrep.dev/r/trailofbits.rs.panic-in-function-returning-result.panic-in-function-returning-result
Cc @thypon @bcaller
Address more clippy lints
zipandenumerateiterator wrappers, which are preferred style since they can optimize better.