Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bulletproofs: add a VerificationScalars struct #75

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Jul 18, 2024

Use a named struct instead of an anonymous tuple to communicate these elements used for InnerProductProof verification within other protocol steps. Makes it easier for the compiler to flag passing the scalars between inappropriate functions.

Addresses a clippy::type_complexity warning.

rillian added 2 commits July 18, 2024 09:35
Use a named struct instead of an anonymous tuple to communicate
these elements used for `InnerProductProof` verification within
other protocol steps. Makes it easier for the compiler to flag
passing the scalars between inappropriate functions.

Addresses a clippy::type_complexity warning.
@rillian rillian requested a review from ankeleralph July 18, 2024 16:44
@rillian rillian self-assigned this Jul 18, 2024
@rillian rillian mentioned this pull request Jul 18, 2024
@rillian rillian requested a review from claucece July 22, 2024 15:05
@claucece
Copy link
Member

This is super!

@rillian rillian merged commit ae866fd into main Jul 23, 2024
3 of 4 checks passed
@rillian rillian deleted the verification_scalars branch July 23, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants