Boomerang spending verify #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just some simple cleanup of the new boomerang code. - Pass single-argument functions directly to map() instead of wrapping them in a redundant closure. - .flat_map() can be faster than .map().flatten() - follow clippy's redundant field names lint even though we're renaming most fields. - Shorter vec-of-constants initializer.
This builds fine with stable rust, at least as of 1.70.
Lint cleanup: - Avoid redundant field names - Remove unnecessary references e.g. .first() and .last() already return references - Prefer slices over `&Vec` as they're more general
Address a `cargo audit` warning about the atty transitive dependency of earlier versions of this benchmark framework. No api changes necessary.
The `#[derive(Clone)]` macro doesn't support marker traits like `BoomerangConfig` so we have to implement this tree manually. Thanks to Sofía Celi for pointing out the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the spend/verify protocol of the boomerang protocol.