OIDC authenticator defaults to using host's root CA pool if CA file is not provided #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stlaz
reviewed
Dec 9, 2024
pkg/authn/oidc.go
Outdated
Comment on lines
42
to
43
| if len(config.CAFile) > 0 { | ||
| dyCA, err := dynamiccertificates.NewDynamicCAContentFromFile("oidc-ca", config.CAFile) |
There was a problem hiding this comment.
nit:
Suggested change
| if len(config.CAFile) > 0 { | |
| dyCA, err := dynamiccertificates.NewDynamicCAContentFromFile("oidc-ca", config.CAFile) | |
| if len(config.CAFile) > 0 { // if unset, the OIDC authenticator defaults to host's trust store | |
| var err error | |
| dynamicCA, err = dynamiccertificates.NewDynamicCAContentFromFile("oidc-ca", config.CAFile) |
Otherwise the change looks good to me.
There was a problem hiding this comment.
Addressed with 84cafeb
Should this be squashed into the previous commit?
…f CA file is not provided
dimityrmirchev
force-pushed
the
default-oidc-root-ca
branch
from
84cafeb to
06bdb53
Compare
|
lgtm, let's wait for the tests to complete |
|
Merging, thank you for your PR 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes an alternative approach to #259 by implementing #259 (comment).
It also aligns the behaviour of the
--oidc-ca-fileflag with its description.Reference to the code that utilises the host's root cert pool when no
CAContentProvideris set https://github.com/kubernetes/kubernetes/blob/c83cbee114ddb732cdc06d3d1b62c9eb9220726f/staging/src/k8s.io/apiserver/plugin/pkg/authenticator/token/oidc/oidc.go#L271-L290