feat: non-doc comments within rsx #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bram209
force-pushed
the
fix-comments-within-rsx
branch
from
4da998d to
cd4871e
Compare
|
Release to crates.io blocked by: stoically/syn-rsx#49 |
|
Works for me! |
bram209
changed the title
bram209
force-pushed
the
main
branch
10 times, most recently
from
76e0705 to
8704edf
Compare
bram209
force-pushed
the
main
branch
2 times, most recently
from
a58efee to
0de7655
Compare
|
Since you moved from syn_rsx to rstml in #32, this probably needs reworking. |
|
Hi, yes this feature can now be implemented, I haven't found the time to do that yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3
Note: Currently inserts the doc comments before a node. Inline (at end of a statement) comments are not yet supported (and will end up in the line above).
Note2: This does not preserve comments in code blocks yet, I plan to add this to https://github.com/bram209/prettyplease later.