FIX: Potential uninitialised value returned if empty string passed to…

… from_string<T>() (#1087)
brainboxdotcc · Feb 19, 2024 · 23a9932 · 23a9932
1 parent fdfe48b
commit 23a9932
Show file tree

Hide file tree

Showing 4 changed files with 283 additions and 21 deletions.
diff --git a/.cspell.json b/.cspell.json
@@ -138,7 +138,10 @@
 		"sku",
 		"skus",
 		"Codecademy",
-		"tparam"
+		"tparam",
+		"khanda",
+		"oclock",
+		"moai"
 	],
 	"flagWords": [
 		"hte"

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -81,6 +81,8 @@
 		"semaphore": "cpp",
 		"stop_token": "cpp",
 		"charconv": "cpp",
-		"any": "cpp"
+		"any": "cpp",
+		"ranges": "cpp",
+		"span": "cpp"
 	}
 }
diff --git a/include/dpp/stringops.h b/include/dpp/stringops.h
@@ -139,6 +139,9 @@ template <typename T> T from_string(const std::string &s, std::ios_base & (*f)(s
  */
 template <typename T> T from_string(const std::string &s)
 {
+	if (s.empty()) {
+		return static_cast<T>(0);
+	}
 	T t;
 	std::istringstream iss(s);
 	iss >> t;