feat: Rename BlockFailedException to AlreadyBlockedException

brainbits · Jan 28, 2025 · b5c9440 · b5c9440
1 parent 6e02db4
commit b5c9440
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/src/Blocker.php b/src/Blocker.php
@@ -13,7 +13,7 @@
 
 namespace Brainbits\Blocking;
 
-use Brainbits\Blocking\Exception\BlockFailedException;
+use Brainbits\Blocking\Exception\AlreadyBlockedException;
 use Brainbits\Blocking\Identity\BlockIdentity;
 use Brainbits\Blocking\Owner\OwnerFactoryInterface;
 use Brainbits\Blocking\Storage\StorageInterface;
@@ -32,7 +32,7 @@ public function block(BlockIdentity $identifier, int|null $ttl = null): Block
         $block = $this->tryBlock($identifier, $ttl);
 
         if ($block === null) {
-            throw BlockFailedException::createAlreadyBlocked($identifier);
+            throw AlreadyBlockedException::createAlreadyBlocked($identifier);
         }
 
         return $block;

diff --git a/src/Exception/BlockFailedException.php → src/Exception/AlreadyBlockedException.php b/src/Exception/BlockFailedException.php → src/Exception/AlreadyBlockedException.php
@@ -17,7 +17,7 @@
 
 use function sprintf;
 
-class BlockFailedException extends RuntimeException
+class AlreadyBlockedException extends RuntimeException
 {
     public static function createAlreadyBlocked(BlockIdentity $identity): self
     {

diff --git a/tests/Functional/FilesystemTest.php b/tests/Functional/FilesystemTest.php
@@ -14,7 +14,7 @@
 namespace Brainbits\Blocking\Tests\Functional;
 
 use Brainbits\Blocking\Blocker;
-use Brainbits\Blocking\Exception\BlockFailedException;
+use Brainbits\Blocking\Exception\AlreadyBlockedException;
 use Brainbits\Blocking\Identity\BlockIdentity;
 use Brainbits\Blocking\Owner\ValueOwnerFactory;
 use Brainbits\Blocking\Storage\FilesystemStorage;
@@ -61,7 +61,7 @@ public function testSelfBlock(): void
 
     public function testOtherBlock(): void
     {
-        $this->expectException(BlockFailedException::class);
+        $this->expectException(AlreadyBlockedException::class);
         $this->expectExceptionMessage('Identifier my_item is already blocked.');
 
         file_put_contents(

diff --git a/tests/Functional/InMemoryTest.php b/tests/Functional/InMemoryTest.php
@@ -15,7 +15,7 @@
 
 use Brainbits\Blocking\Block;
 use Brainbits\Blocking\Blocker;
-use Brainbits\Blocking\Exception\BlockFailedException;
+use Brainbits\Blocking\Exception\AlreadyBlockedException;
 use Brainbits\Blocking\Identity\BlockIdentity;
 use Brainbits\Blocking\Owner\Owner;
 use Brainbits\Blocking\Owner\ValueOwnerFactory;
@@ -56,7 +56,7 @@ public function testSelfBlock(): void
 
     public function testOtherBlock(): void
     {
-        $this->expectException(BlockFailedException::class);
+        $this->expectException(AlreadyBlockedException::class);
         $this->expectExceptionMessage('Identifier my_item is already blocked.');
 
         $storage = new InMemoryStorage($this->clock);

diff --git a/tests/Functional/PredisTest.php b/tests/Functional/PredisTest.php
@@ -14,7 +14,7 @@
 namespace Brainbits\Blocking\Tests\Functional;
 
 use Brainbits\Blocking\Blocker;
-use Brainbits\Blocking\Exception\BlockFailedException;
+use Brainbits\Blocking\Exception\AlreadyBlockedException;
 use Brainbits\Blocking\Identity\BlockIdentity;
 use Brainbits\Blocking\Owner\ValueOwnerFactory;
 use Brainbits\Blocking\Storage\PredisStorage;
@@ -67,7 +67,7 @@ public function testSelfBlock(): void
 
     public function testOtherBlock(): void
     {
-        $this->expectException(BlockFailedException::class);
+        $this->expectException(AlreadyBlockedException::class);
         $this->expectExceptionMessage('Identifier my_item is already blocked.');
 
         $this->client->set('block:my_item', json_encode(['identity' => 'my_item', 'owner' => 'other_owner']));