Skip to content
This repository has been archived by the owner on Oct 7, 2022. It is now read-only.

Implemented convertion from NSLocalizedString into structured enums #25

Merged
merged 4 commits into from
Jul 14, 2017
Merged

Implemented convertion from NSLocalizedString into structured enums #25

merged 4 commits into from
Jul 14, 2017

Conversation

unnamedd
Copy link
Contributor

@unnamedd unnamedd commented Jul 8, 2017

closes #24

@florianbuerger
Copy link
Collaborator

Thanks, did you use SwiftGen or something similar? If so, would be great if there would also be a Build Phase to automatically create the enums.

@unnamedd
Copy link
Contributor Author

unnamedd commented Jul 8, 2017

@florianbuerger no. I did it all myself. Any tool like SwiftGen or similar will create these enums in multi-levels. I believe that these multi-levels are the key to make it useful when we are using throughout the code.

This kind of thing just needs to be done when we are working on something new, I'm sure that we won't need to care about an automatic generation. Thoughts ?

@unnamedd
Copy link
Contributor Author

unnamedd commented Jul 8, 2017

@florianbuerger the conflicts are gone! ;)

@unnamedd
Copy link
Contributor Author

@florianbuerger any thoughts about this PR ? Is it insteresting ?

@florianbuerger
Copy link
Collaborator

Hey, so sorry for my late reply.

I think you are right. We'll keep the manual version for now. If for whatever reason there are tons of new strings, swiftgen could be an option.

@florianbuerger florianbuerger merged commit 8354201 into br1sk:master Jul 14, 2017
@unnamedd
Copy link
Contributor Author

@florianbuerger yeah. Isn't hard to create these items manually, to be honest, I prefer to do this like that. Will only be a good option, if these tools could understand the use of our separador (.) and create these enums, but in the end, we will need to check it to ensure that is all okay.

@unnamedd unnamedd deleted the enhancement/convert-localized-into-enum branch July 14, 2017 23:11
@florianbuerger
Copy link
Collaborator

Oh swiftgen does understand them. It creates nested enums as well 😉

@unnamedd
Copy link
Contributor Author

unnamedd commented Jul 15, 2017

Really ?! This is awesome! I'll take a look on it!

ethanhuang13 added a commit to ethanhuang13/brisk-ios that referenced this pull request Jul 19, 2018
@ethanhuang13 ethanhuang13 mentioned this pull request Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert NSLocalizedStrings into structured enums
2 participants