Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BPMN MIWG 2023 demo results to reference #912

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

barmac
Copy link
Contributor

@barmac barmac commented Dec 4, 2024

This PR adds the 2023 demo results to the Reference directory. The models used are from the live demo folder, and the renderings were produced with bpmn-to-image, equivalent to Camunda Desktop Modeler rendering.

Copy link
Contributor

@SimonRinguette SimonRinguette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also a need to modify the test-case-structure.json at the root to add this test case

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This model has a lane that goes over the pool header. This should be corrected.

<callActivity name="Document Request"
id="_1c9f4f0d-d193-4643-8201-0843a9a937fe"
isForCompensation="false"
calledElement="process_1c9f4f0d-d193-4643-8201-0843a9a937fe"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The called element here is not defined or imported, there is no way to know if the + marker should be displayed in the diagram.

@barmac
Copy link
Contributor Author

barmac commented Dec 4, 2024

@barmac to use the reference models instead

@barmac barmac marked this pull request as draft December 4, 2024 15:54
@barmac barmac self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants