chore: fix internal usePrevious hooks

Related to #972 (comment)
bpmn-io · Jan 11, 2024 · d75b7a7 · d75b7a7
1 parent 0f043bd
commit d75b7a7
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/packages/form-js-editor/src/render/hooks/usePrevious.js b/packages/form-js-editor/src/render/hooks/usePrevious.js
@@ -1,13 +1,15 @@
 import {
-  useEffect,
-  useRef
+  useState
 } from 'preact/hooks';
 
-
 export function usePrevious(value, defaultValue = null) {
-  const ref = useRef(defaultValue);
+  const [ current, setCurrent ] = useState(value);
+  const [ previous, setPrevious ] = useState(defaultValue);
 
-  useEffect(() => ref.current = value, [ value ]);
+  if (value !== current) {
+    setPrevious(current);
+    setCurrent(value);
+  }
 
-  return ref.current;
+  return previous;
 }
diff --git a/packages/form-js-viewer/src/render/hooks/usePrevious.js b/packages/form-js-viewer/src/render/hooks/usePrevious.js
@@ -1,13 +1,15 @@
 import {
-  useEffect,
-  useRef
+  useState
 } from 'preact/hooks';
 
-
 export function usePrevious(value, defaultValue = null) {
-  const ref = useRef(defaultValue);
+  const [ current, setCurrent ] = useState(value);
+  const [ previous, setPrevious ] = useState(defaultValue);
 
-  useEffect(() => ref.current = value, [ value ]);
+  if (value !== current) {
+    setPrevious(current);
+    setCurrent(value);
+  }
 
-  return ref.current;
+  return previous;
 }