Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adds Query Include/Exclude Package #58

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Conversation

jdamner
Copy link
Collaborator

@jdamner jdamner commented Jul 12, 2024

Change Details

A project suggested it would be great to have the ability to specify which posts are included or excluded from a query-loop block. This package aims to provide this feature. The functionality already exists in core, but there's no interface to control it. At the moment this package provides a simple interface.

Further enhancements could be acheievd in the future, such as limiting the number of selectable posts to include to the same limit as the query and only returning posts that meet other filters selected in the query for the include/exclude.

Also, there's potential performance issues if the number of posts or pages is excessive so we could look at more lazily loading these.

Screenshots

Screenshot 2024-07-12 at 16 35 31

Copy link
Member

@Ritchbox Ritchbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdamner jdamner force-pushed the query-include-exclude branch from 7825ab7 to 0c05a2b Compare July 15, 2024 12:17
Change Details
-------------
A project suggested it would be great to have the ability to specify
which posts are included or excluded from a query-loop block. This
package aims to provide this feature. The functionality already exists
in core, but there's no interface to control it. At the moment this
package provides a simple interface.

Further enhancements could be acheievd in the future, such as limiting
the number of selectable posts to include to the same limit as the query
and only returning posts that meet other filters selected in the query
for the include/exclude.

Also, there's potential performance issues if the number of posts or pages
is excessive so we could look at more lazily loading these.
@jdamner jdamner force-pushed the query-include-exclude branch from 0c05a2b to 68cac14 Compare July 15, 2024 15:18
@jdamner jdamner merged commit fd790f9 into main Jul 15, 2024
8 checks passed
@jdamner jdamner deleted the query-include-exclude branch July 15, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants