Updated script to not allow password login by default #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ubuntu1804
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scripts currently create VMs which have a default username and password, as well as Vagrant's insecure key. The key will be replaced when the box is deployed with Vagrant, however the password is never changed and SSH is forwarded to the VM by default.
This patch improves security by making sure a VM built with packer and deployed with Vagrant is fully patched, doesn't have a known SSH key pair, and does not allow SSH password login. All of this can be changed by the user to get the previous behavior by changing the update variable and the newly added ssh_disable_password_auth to true.
A side effect of doing the security updates before building the box file is an efficiency gain over doing updates at deploy time for every VM. The version was also incremented because this changes the default behavior of how the VM is built.