Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isfinite, fix pvode linking #3063

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Use isfinite, fix pvode linking #3063

merged 3 commits into from
Jan 21, 2025

Conversation

bendudson
Copy link
Contributor

Should fix issue #3060 , building on MacOS

  • Use std::isfinite rather than the non-standard finite function
  • Link PVODE pvpre library against pvode library

also:

  • Update copyright notices in touched files

@bendudson
Replace finite() with std::isfinite()
5083f30 
`finite()` is a BSD extension for C that is widely supported
but not standard. Fails to compile under MacOS.
@bendudson
Update some copyright notices
d09611a 
Drive-by updates of touched files.
@bendudson
pvpre library should link against pvode
5a2e624 
pvpre file pvbbdpre.cpp uses routines in pvode nvector.cpp, so should
link against pvode. This resolves an issue on MacOS (at least locally).
dschwoerer
dschwoerer approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@dschwoerer dschwoerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bendudson

@bendudson bendudson merged commit 0c733e4 into next Jan 21, 2025
27 of 28 checks passed
@bendudson bendudson deleted the next-use-isfinite branch January 21, 2025 17:15
@bendudson bendudson mentioned this pull request Jan 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwoerer dschwoerer dschwoerer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bendudson @dschwoerer