Fixing elm-pb example to match v3 results #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Matching versions of elm_pb example code, separating out whitespace changes first.
These factors bring the linear growth rates in line with BOUT++ v3.x There are still unexplained oscillations and mode coupling to investigate.
Plots an analysis of linear growth rate.
ZedThree
previously approved these changes
Nov 14, 2023
Like the elm-pb example, add B0 factors so that we're solving the same equations as BOUT++ v3.x
dschwoerer
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working through terms, to ensure that results are the same or differences are understood.
Mainly changes worked out by Nami Li.