Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Semantic tag with wikidata api #468

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Semantic tag with wikidata api #468

merged 7 commits into from
Nov 21, 2023

Conversation

Simurgan
Copy link
Member

Wikidata API has been utilized and semantic tag model / class has been updated accordingly.
Unit tests were also implemented.
Wikidata API methods can be found in the wikidata.py file.

Successful merge of this pull request closes #451 and #453

@Simurgan Simurgan added priority: critical This issue requires immediate attention to prevent major issues or disruptions. type: research This issue requires research or investigation before a solution or implementation can be proposed. size: large Requires significant effort and may take several weeks to months to complete. difficulty: challenging Requires advanced skills, knowledge, and may involve complex problems or significant research/collab type: implementation This issue is related to implementation backend issues related to backend labels Nov 20, 2023
@Simurgan Simurgan self-assigned this Nov 20, 2023
@hakanaktas0
Copy link
Contributor

Please remove the lab report from this PR

hakanaktas0
hakanaktas0 approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@hakanaktas0 hakanaktas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good. Ready to merge.

@Simurgan Simurgan merged commit 5ddad6a into backend Nov 21, 2023
1 check passed
This was linked to issues Dec 1, 2023
Semantic Tag Class/Model Update #451
Closed
Third party API research and utilization for semantic tag functionality #453
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakanaktas0 hakanaktas0 hakanaktas0 approved these changes

@Bera0422 Bera0422 Awaiting requested review from Bera0422

Assignees

@Simurgan Simurgan

Labels
backend issues related to backend difficulty: challenging Requires advanced skills, knowledge, and may involve complex problems or significant research/collab priority: critical This issue requires immediate attention to prevent major issues or disruptions. size: large Requires significant effort and may take several weeks to months to complete. type: implementation This issue is related to implementation type: research This issue requires research or investigation before a solution or implementation can be proposed.
Projects
None yet
Milestone
CMPE451 Customer Milestone 2: Present...
Development

Successfully merging this pull request may close these issues.

Third party API research and utilization for semantic tag functionality Semantic Tag Class/Model Update
2 participants
@Simurgan @hakanaktas0