Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of Request POST Methods #457

Closed
wants to merge 40 commits into from
Closed

Conversation

Bera0422
Copy link
Contributor

Implemented required methods to send collaboration/review requests and update request status. Unit tests are also implemented. This PR fixes #445

@Bera0422 Bera0422 added type: implementation This issue is related to implementation backend issues related to backend labels Nov 15, 2023
@Bera0422 Bera0422 self-assigned this Nov 15, 2023
@Bera0422 Bera0422 requested a review from hakanaktas0 November 15, 2023 20:29
Copy link
Contributor

@hakanaktas0 hakanaktas0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you implemented these before the workspace class PR was merged. I think you should pull the backend again and revise your implementation.
One of the many issues I encountered: The collab request post api tries to insert to the database using 'id' field of the workspace table. The workspace table uses 'workspace_id' as its primary key.
It was really hard to make database function properly after the changes in the workspace class PR so please do not make migrations before pulling the latest version of the backend.

hakanaktas0 and others added 6 commits November 17, 2023 00:04
Implemented POST for sending collaboration requests
Implemented PUT Status Update for Requests
Implemented POST for sending review requests with unit tests
Changed id to workspace_id in order to access the workspace.
@Bera0422
Copy link
Contributor Author

I believe you implemented these before the workspace class PR was merged. I think you should pull the backend again and revise your implementation. One of the many issues I encountered: The collab request post api tries to insert to the database using 'id' field of the workspace table. The workspace table uses 'workspace_id' as its primary key. It was really hard to make database function properly after the changes in the workspace class PR so please do not make migrations before pulling the latest version of the backend.

I pulled the changes from the "backend" branch and revised the id access to use "workspace_id". Unit tests are completed successfully.

@Bera0422 Bera0422 requested a review from hakanaktas0 November 16, 2023 22:08
@Bera0422 Bera0422 closed this Nov 17, 2023
@Bera0422 Bera0422 deleted the request-post-api branch November 17, 2023 15:49
@Bera0422
Copy link
Contributor Author

Apparently, things went wrong. I will reopen the branch and the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend issues related to backend type: implementation This issue is related to implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants