Rpcv2 cbor protocol support #3391
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will fail until #boto#3247 is merged and this is properly rebased. This is intentional - because there's this parallel work going on, this is an easy way to make sure we don't forget the step of merging the protocol tests
These tests are specific to CBOR and the CBOR parser and prescribed upstream as part of the spec.
- whitespace changes - removed a bunch of copy/pasted comments - removed some code that was also copy/pasted and not relevant to the new classes - removed old TODOS, added some new ones
Add the removed tests back in and add an ignore list to skip the tests which are for generic, non AWS specific CBOR behavior that is not supported by us
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial draft of the parsers section of the RPCv2CBOR protocol. There are still a large number of TODOs to be addressed.
Note that it is currently expected that a number of tests will fail as this needs to be rebased/updated after #3247 is merged. The protocol tests are non-functional and will continue to be until this rebase.
This also will fail some of the checks from the recently merged
protocolstrait support- we will need to add the Serializer in another PR as well as RPCv2CBOR to the priority ordered protocols list before this passes.