Issue with Events and secondary drivers that extends TelegramDriver m…

…ain class (#12) * Secondary Telegram drivers doesn't have any Event so should all be ignored at all * Style fix * Added some tests (not very necessary)
botman · Sep 3, 2017 · c12d2f2 · c12d2f2
1 parent d0333ca
commit c12d2f2
Show file tree

Hide file tree

Showing 10 changed files with 175 additions and 0 deletions.
diff --git a/src/TelegramAudioDriver.php b/src/TelegramAudioDriver.php
@@ -20,6 +20,14 @@ public function matchesRequest()
         return ! is_null($this->event->get('from')) && (! is_null($this->event->get('audio')) || ! is_null($this->event->get('voice')));
     }
 
+    /**
+     * @return bool
+     */
+    public function hasMatchingEvent()
+    {
+        return false;
+    }
+
     /**
      * Retrieve the chat message.
      *

diff --git a/src/TelegramFileDriver.php b/src/TelegramFileDriver.php
@@ -20,6 +20,14 @@ public function matchesRequest()
         return ! is_null($this->event->get('from')) && (! is_null($this->event->get('document')));
     }
 
+    /**
+     * @return bool
+     */
+    public function hasMatchingEvent()
+    {
+        return false;
+    }
+
     /**
      * Retrieve the chat message.
      *

diff --git a/src/TelegramLocationDriver.php b/src/TelegramLocationDriver.php
@@ -19,6 +19,14 @@ public function matchesRequest()
         return ! is_null($this->event->get('from')) && ! is_null($this->event->get('location'));
     }
 
+    /**
+     * @return bool
+     */
+    public function hasMatchingEvent()
+    {
+        return false;
+    }
+
     /**
      * Retrieve the chat message.
      *

diff --git a/src/TelegramPhotoDriver.php b/src/TelegramPhotoDriver.php
@@ -21,6 +21,14 @@ public function matchesRequest()
         return ! is_null($this->event->get('from')) && ! is_null($this->event->get('photo'));
     }
 
+    /**
+     * @return bool
+     */
+    public function hasMatchingEvent()
+    {
+        return false;
+    }
+
     /**
      * Retrieve the chat message.
      *

diff --git a/src/TelegramVideoDriver.php b/src/TelegramVideoDriver.php
@@ -20,6 +20,14 @@ public function matchesRequest()
         return ! is_null($this->event->get('from')) && ! is_null($this->event->get('video'));
     }
 
+    /**
+     * @return bool
+     */
+    public function hasMatchingEvent()
+    {
+        return false;
+    }
+
     /**
      * Retrieve the chat message.
      *

diff --git a/tests/TelegramAudioDriverTest.php b/tests/TelegramAudioDriverTest.php
@@ -240,4 +240,31 @@ public function it_throws_exception_in_get_attachment_url()
             $this->assertSame(TelegramAttachmentException::class, get_class($t));
         }
     }
+
+    /** @test */
+    public function it_havent_to_match_any_event()
+    {
+        $driver = $this->getDriver([
+            'update_id' => '1234567890',
+            'message' => [
+                'message_id' => '123',
+                'from' => [
+                    'id' => 'from_id',
+                ],
+                'chat' => [
+                    'id' => 'chat_id',
+                ],
+                'date' => '1480369277',
+                'text' => 'Hi Julia',
+                'new_chat_member' => [
+                    'id' => '456',
+                    'first_name' => 'Marcel',
+                    'last_name' => 'Pociot',
+                    'username' => 'mpociot',
+                ],
+            ],
+        ]);
+        $this->assertFalse($driver->matchesRequest());
+        $this->assertFalse($driver->hasMatchingEvent());
+    }
 }
diff --git a/tests/TelegramFileDriverTest.php b/tests/TelegramFileDriverTest.php
@@ -169,4 +169,31 @@ public function it_throws_exception_in_get_attachment_url()
             $this->assertSame(TelegramAttachmentException::class, get_class($t));
         }
     }
+
+    /** @test */
+    public function it_havent_to_match_any_event()
+    {
+        $driver = $this->getDriver([
+            'update_id' => '1234567890',
+            'message' => [
+                'message_id' => '123',
+                'from' => [
+                    'id' => 'from_id',
+                ],
+                'chat' => [
+                    'id' => 'chat_id',
+                ],
+                'date' => '1480369277',
+                'text' => 'Hi Julia',
+                'new_chat_member' => [
+                    'id' => '456',
+                    'first_name' => 'Marcel',
+                    'last_name' => 'Pociot',
+                    'username' => 'mpociot',
+                ],
+            ],
+        ]);
+        $this->assertFalse($driver->matchesRequest());
+        $this->assertFalse($driver->hasMatchingEvent());
+    }
 }
diff --git a/tests/TelegramLocationDriverTest.php b/tests/TelegramLocationDriverTest.php
@@ -105,4 +105,31 @@ public function it_returns_the_location()
             'longitude' => -122.123854248,
         ], $location->getPayload());
     }
+
+    /** @test */
+    public function it_havent_to_match_any_event()
+    {
+        $driver = $this->getDriver([
+            'update_id' => '1234567890',
+            'message' => [
+                'message_id' => '123',
+                'from' => [
+                    'id' => 'from_id',
+                ],
+                'chat' => [
+                    'id' => 'chat_id',
+                ],
+                'date' => '1480369277',
+                'text' => 'Hi Julia',
+                'new_chat_member' => [
+                    'id' => '456',
+                    'first_name' => 'Marcel',
+                    'last_name' => 'Pociot',
+                    'username' => 'mpociot',
+                ],
+            ],
+        ]);
+        $this->assertFalse($driver->matchesRequest());
+        $this->assertFalse($driver->hasMatchingEvent());
+    }
 }
diff --git a/tests/TelegramPhotoDriverTest.php b/tests/TelegramPhotoDriverTest.php
@@ -177,4 +177,31 @@ public function it_throws_exception_in_get_attachment_url()
             $this->assertSame(TelegramAttachmentException::class, get_class($t));
         }
     }
+
+    /** @test */
+    public function it_havent_to_match_any_event()
+    {
+        $driver = $this->getDriver([
+            'update_id' => '1234567890',
+            'message' => [
+                'message_id' => '123',
+                'from' => [
+                    'id' => 'from_id',
+                ],
+                'chat' => [
+                    'id' => 'chat_id',
+                ],
+                'date' => '1480369277',
+                'text' => 'Hi Julia',
+                'new_chat_member' => [
+                    'id' => '456',
+                    'first_name' => 'Marcel',
+                    'last_name' => 'Pociot',
+                    'username' => 'mpociot',
+                ],
+            ],
+        ]);
+        $this->assertFalse($driver->matchesRequest());
+        $this->assertFalse($driver->hasMatchingEvent());
+    }
 }
diff --git a/tests/TelegramVideoDriverTest.php b/tests/TelegramVideoDriverTest.php
@@ -188,4 +188,31 @@ public function it_throws_exception_in_get_attachment_url()
             $this->assertSame(TelegramAttachmentException::class, get_class($t));
         }
     }
+
+    /** @test */
+    public function it_havent_to_match_any_event()
+    {
+        $driver = $this->getDriver([
+            'update_id' => '1234567890',
+            'message' => [
+                'message_id' => '123',
+                'from' => [
+                    'id' => 'from_id',
+                ],
+                'chat' => [
+                    'id' => 'chat_id',
+                ],
+                'date' => '1480369277',
+                'text' => 'Hi Julia',
+                'new_chat_member' => [
+                    'id' => '456',
+                    'first_name' => 'Marcel',
+                    'last_name' => 'Pociot',
+                    'username' => 'mpociot',
+                ],
+            ],
+        ]);
+        $this->assertFalse($driver->matchesRequest());
+        $this->assertFalse($driver->hasMatchingEvent());
+    }
 }