Always reply in existing threads #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rzumer
force-pushed
the
reply-in-existing-threads
branch
from
c1e2a14 to
08859c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my opinion there is no reason for the bot to be replying to a message sent in a thread directly in the channel.
replyInThread()is not adequate because it always creates a new thread if there isn't one already (plus it is annoying to use in conjunction with other drivers that don't have that function).Keeping things simple, set the thread when building the payload for the reply. If using
replyInThread(). This also reverts botman/botman#328 since the thread ID will be overridden inbuildServicePayload()if it already exists anyway.Applying unrelated StyleCI diff in the same commit.