Adoptions for Diagnostics (#75)

* 90 percent only and ignoring Changelog Signed-off-by: Christian Henkel <[email protected]> * license in code is declared correctly Signed-off-by: Christian Henkel <[email protected]> * also here bsd-3-clause is correct Signed-off-by: Christian Henkel <[email protected]> --------- Signed-off-by: Christian Henkel <[email protected]>
boschresearch · Jan 27, 2025 · a16a2aa · a16a2aa
1 parent 3c08378
commit a16a2aa
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/ros_license_toolkit/common.py b/src/ros_license_toolkit/common.py
@@ -19,10 +19,11 @@
 import os
 from typing import Any, Dict, List, Optional
 
-REQUIRED_PERCENTAGE_OF_LICENSE_TEXT = 95.0
+REQUIRED_PERCENTAGE_OF_LICENSE_TEXT = 90.0
 
 # files we ignore in scan results
 IGNORED = [
+    "CHANGELOG.rst",
     ".scanignore",
     "package.xml",
     "setup.py",

diff --git a/test/systemtest/test_separate_pkgs.py b/test/systemtest/test_separate_pkgs.py
@@ -163,7 +163,7 @@ def test_pkg_one_correct_one_license_file_missing(self):
         process, stdout = open_subprocess("test_pkg_one_correct_one_license_file_missing")
         self.assertEqual(os.EX_DATAERR, process.returncode)
         self.assertTrue(
-            check_output_status(stdout, WARNING, SUCCESS, WARNING, FAILURE, FAILURE, SUCCESS)
+            check_output_status(stdout, WARNING, SUCCESS, WARNING, FAILURE, SUCCESS, SUCCESS)
         )
 
     def test_pkg_scheme1_conform(self):
@@ -274,9 +274,10 @@ def test_pkg_with_multiple_licenses_one_referenced_incorrect(self):
             "test_pkg_with_multiple_licenses_one_referenced_incorrect"
         )
         self.assertEqual(os.EX_OK, process.returncode)
+        print(stdout)
         self.assertIn(b"WARNING Licenses ['BSD'] are not in SPDX list", stdout)
         self.assertTrue(
-            check_output_status(stdout, WARNING, SUCCESS, WARNING, WARNING, WARNING, WARNING)
+            check_output_status(stdout, WARNING, SUCCESS, WARNING, WARNING, SUCCESS, WARNING)
         )
 
     def test_pkg_wrong_license_file(self):