Stop TCP interfaces and RPC connections on shutdown #3307
Conversation
source/agora/network/VibeManager.d
Outdated
| @@ -59,13 +59,23 @@ shared static this () | |||
| /// And implementation of `agora.network.Manager : NetworkManager` using Vibe.d | |||
| public final class VibeNetworkManager : NetworkManager | |||
| { | |||
| private RPCClient!(agora.api.Validator.API)[] rpc_clients; | |||
There was a problem hiding this comment.
Cant we just close() the socket in RPCClient dtor?
There was a problem hiding this comment.
I think all interface and connections should be closed before invoking node's shutdown procedure. But this might cause holding an unnecessary reference for cases where a connection is banned . I will think a better approach.
There was a problem hiding this comment.
I've updated it with new approach, ready to review
Codecov Report
@@ Coverage Diff @@
## v0.x.x #3307 +/- ##
==========================================
+ Coverage 87.88% 88.92% +1.04%
==========================================
Files 164 165 +1
Lines 16975 17108 +133
==========================================
+ Hits 14918 15213 +295
+ Misses 2057 1895 -162
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Towards a better shutdown procedure
This will reduce the number of eventcore leaks during shutdown, only DNS UDP connection will be remaining as leaking.
Part of #3158
depends on #3311 and bosagora/localrest#6