Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration tests: Use node-0 as DNS server #3096

Draft
wants to merge 1 commit into
base: v0.x.x
Choose a base branch
from

Conversation

Geod24
Copy link
Collaborator

@Geod24 Geod24 commented Feb 23, 2022

Let's see what the CI thinks of this.

@Geod24 Geod24 marked this pull request as draft February 23, 2022 10:53
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #3096 (ac7e3b1) into v0.x.x (f27135d) will decrease coverage by 8.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           v0.x.x    #3096      +/-   ##
==========================================
- Coverage   87.43%   79.27%   -8.17%     
==========================================
  Files         163      210      +47     
  Lines       16530    18830    +2300     
==========================================
+ Hits        14453    14927     +474     
- Misses       2077     3903    +1826     
Flag Coverage Δ
integration 26.91% <ø> (?)
unittests 87.31% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/common/Task.d 88.88% <0.00%> (-11.12%) ⬇️
source/agora/test/LocalTransactions.d 86.66% <0.00%> (-4.45%) ⬇️
source/agora/consensus/protocol/Nominator.d 90.87% <0.00%> (-1.70%) ⬇️
source/agora/consensus/state/Ledger.d 90.21% <0.00%> (-0.73%) ⬇️
source/agora/node/Validator.d 93.01% <0.00%> (-0.51%) ⬇️
source/agora/network/Manager.d 82.77% <0.00%> (-0.34%) ⬇️
source/agora/consensus/EnrollmentManager.d 97.35% <0.00%> (-0.30%) ⬇️
source/agora/script/Engine.d 97.59% <0.00%> (-0.16%) ⬇️
source/agora/test/Flash.d 95.12% <0.00%> (-0.11%) ⬇️
agora/submodules/ocean/src/ocean/core/Enforce.d 0.00% <0.00%> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f27135d...ac7e3b1. Read the comment docs.

@Geod24
Copy link
Collaborator Author

Geod24 commented Mar 14, 2022

Well we probably need to cross the Rubicon and parse /etc/resolv.conf for this to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant