Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many transactions unit test #2749

Open
wants to merge 1 commit into
base: v0.x.x
Choose a base branch
from

Conversation

hewison-chris
Copy link
Contributor

This is a network unit test which keeps increasing the number of
transactions sent to be externalized. This is to test the gossiping and
consensus protocol implementation works with large numbers of
transactions.

@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #2749 (ff9d8bb) into v0.x.x (9d28f5c) will decrease coverage by 0.01%.
The diff coverage is 95.00%.

@@            Coverage Diff             @@
##           v0.x.x    #2749      +/-   ##
==========================================
- Coverage   87.83%   87.82%   -0.02%     
==========================================
  Files         164      165       +1     
  Lines       16932    16954      +22     
==========================================
+ Hits        14873    14890      +17     
- Misses       2059     2064       +5     
Flag Coverage Δ
unittests 87.82% <95.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
source/agora/test/ManyTransactions.d 95.00% <95.00%> (ø)
source/scpd/scp/SCPDriver.d 60.00% <0.00%> (-15.00%) ⬇️
source/agora/node/FullNode.d 72.44% <0.00%> (-1.24%) ⬇️
source/agora/test/ValidatorRecurringEnrollment.d 94.23% <0.00%> (-0.97%) ⬇️
source/agora/consensus/state/Ledger.d 89.73% <0.00%> (-0.67%) ⬇️
source/agora/node/Validator.d 90.90% <0.00%> (-0.51%) ⬇️
source/agora/network/Manager.d 77.84% <0.00%> (-0.32%) ⬇️
source/agora/test/Flash.d 95.12% <0.00%> (-0.11%) ⬇️
source/agora/consensus/protocol/Nominator.d 91.28% <0.00%> (+0.17%) ⬆️
source/agora/flash/Node.d 80.88% <0.00%> (+0.21%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d28f5c...ff9d8bb. Read the comment docs.

@omerfirmak
Copy link
Contributor

I see this is still failing, so we should probably wait on merging it.

@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch 2 times, most recently from 46709f7 to 7d7d064 Compare December 24, 2021 01:28
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch 7 times, most recently from f57aa3b to 50f7f98 Compare January 5, 2022 06:38
@hewison-chris hewison-chris self-assigned this Feb 3, 2022
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch from 50f7f98 to d149336 Compare February 3, 2022 07:55
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch 2 times, most recently from c4db7bc to 0e96549 Compare February 22, 2022 01:31
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch 2 times, most recently from c5f89fc to 0570195 Compare March 15, 2022 22:08
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch from 0570195 to 3d7c796 Compare March 22, 2022 09:45
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch from 3d7c796 to f217c23 Compare April 11, 2022 02:04
This is a network unit test which keeps increasing the number of
transactions sent to be externalized. This is to test the gossiping and
consensus protocol implementation works with large numbers of
transactions.
@hewison-chris hewison-chris force-pushed the issue2653_many_transactions branch from f217c23 to ff9d8bb Compare April 12, 2022 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants