Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erase(iterator) perf #138

Merged
merged 2 commits into from
Jul 27, 2022
Merged

erase(iterator) perf #138

merged 2 commits into from
Jul 27, 2022

Conversation

cmazakas
Copy link
Member

Add a dedicated erase_node() function to the table class used internally by the implementation, creating optimizer-friendly code for cl.exe.

Partially addresses #137

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #138 (a31e894) into develop (3abe5de) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #138      +/-   ##
===========================================
- Coverage    97.28%   97.28%   -0.01%     
===========================================
  Files           75       75              
  Lines         9943     9941       -2     
===========================================
- Hits          9673     9671       -2     
  Misses         270      270              
Impacted Files Coverage Δ
include/boost/unordered/detail/implementation.hpp 98.57% <100.00%> (+0.01%) ⬆️
include/boost/unordered/unordered_map.hpp 99.84% <100.00%> (-0.01%) ⬇️
include/boost/unordered/unordered_set.hpp 98.90% <100.00%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3abe5de...a31e894. Read the comment docs.

@pdimov pdimov requested a review from joaquintides July 26, 2022 17:19
@pdimov pdimov merged commit a4c6bf9 into boostorg:develop Jul 27, 2022
@cmazakas cmazakas deleted the feature/erase-perf branch July 27, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants